Improved dark mode UI consistency across the application. - #248
Conversation
|
@SRSoham is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
gssoc-2026
type:accessibility
ui
and removed
gssoc-2026
labels
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Hi @komalharshita , Thank you! |
|
@SRSoham you will have to resolve the merge conflicts before merging However, before this PR can be approved, please update the PR description using the repository’s required PR template and properly link the related issue (for example using Maintaining consistent PR formatting and issue linkage is important for project tracking, review clarity, and GSSoC contribution validation. Please make those updates and request re-review afterward. |
SRSoham
changed the title
|
@komalharshita Merge conflicts resolved and PR description updated with the required template and linked issue. Ready for re-review. |
|
@SRSoham merge conflicts still exist |
|
@komalharshita merge conflicts have been resolved and changes pushed. Ready for re-review. |
komalharshita
left a comment
komalharshita
left a comment
There was a problem hiding this comment.
Thanks for the substantial contribution. The dark mode feature is valuable and it’s clear a significant amount of effort went into improving consistency across many sections of the application.
The theme toggle persistence logic is implemented well, and the PR meaningfully improves the overall user experience.
However, before this can be approved, there are several maintainability and architecture concerns that should be addressed:
-
The implementation relies heavily on
!importantacross a very large number of selectors. This makes long-term maintenance and future styling changes difficult. -
The PR introduces a massive monolithic dark-mode override block instead of using a cleaner theme-variable/token-based structure.
-
Because many unrelated components are modified simultaneously, there is elevated regression risk for hover states, responsiveness, spacing, and contrast consistency.
-
Please provide clearer testing evidence/screenshots for:
- all major sections in dark mode
- mobile responsiveness
- forms/cards/buttons
- accessibility contrast validation
Recommended improvements:
- reduce unnecessary
!importantusage - consolidate repeated colors into reusable CSS variables
- group dark mode styles by component/section for readability
- clean up duplicate/redundant selectors where possible
This is a strong foundation, but it needs refactoring and cleanup before it is merge-ready.
|
Thank you for the detailed review and feedback. I understand the maintainability concerns regarding the extensive use of I’ll work on:
I appreciate the guidance and will push the refactored changes soon. |
2 participants
Changes Made
Related Issue
Closes #248